Skip to content

Improve descriptions of snooz.transition_xx actions#138403

Merged
frenck merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-18
Feb 14, 2025
Merged

Improve descriptions of snooz.transition_xx actions#138403
frenck merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-18

Conversation

@NoRi2909
Copy link
Copy Markdown
Contributor

Proposed change

The current action descriptions of the snooz integration are easy to misunderstand and result in wrong translations.
For example "over time" should be "over a specified duration".

This commit replaces them with the better wording from the online docs, slightly adapted for the UI that already displays the units and ranges.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

The current action descriptions of the snooz integration are easy to misunderstand and result in wrong translations.

This commit replaces them with the wording from the online docs, slightly adapted for the UI that already displays the units and ranges.
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @AustinBrunkhorst, mind taking a look at this pull request as it has been labeled with an integration (snooz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of snooz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign snooz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NoRi2909 👍

../Frenck

@frenck frenck merged commit b9148d6 into home-assistant:dev Feb 14, 2025
@NoRi2909 NoRi2909 deleted the patch-18 branch February 14, 2025 16:50
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants