Skip to content

Add sensors for pellets boiler in ViCare integration#138563

Merged
zweckj merged 7 commits intohome-assistant:devfrom
CFenner:buffer
Feb 19, 2025
Merged

Add sensors for pellets boiler in ViCare integration#138563
zweckj merged 7 commits intohome-assistant:devfrom
CFenner:buffer

Conversation

@CFenner
Copy link
Copy Markdown
Contributor

@CFenner CFenner commented Feb 14, 2025 •
edited
Loading

Proposed change

  • add buffer sensors (expose by pellets boiler)
  • add fuel need sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner CFenner changed the title Add buffer sensors for pellets boiler in ViCare integration Add sensors for pellets boiler in ViCare integration Feb 14, 2025
CFenner
CFenner commented Feb 14, 2025
View reviewed changes
Comment thread homeassistant/components/vicare/sensor.py
state_class=SensorStateClass.MEASUREMENT,
entity_category=EntityCategory.DIAGNOSTIC,
native_unit_of_measurement=UnitOfMass.KILOGRAMS,
value_getter=lambda api: api.getFuelNeed(),
Copy link
Copy Markdown
Contributor Author

@CFenner CFenner Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majofi01 what exactly is the fuel need? In the API it's listed under the configuration section, so I guess it's not the actual pellets consumption (per day?), right?

Copy link
Copy Markdown
Member

@zweckj zweckj Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR looks fine, do you want for a reponse here @CFenner?

Copy link
Copy Markdown
Contributor Author

@CFenner CFenner Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we could change the labeling later on, if necessary.

@CFenner
Copy link
Copy Markdown
Contributor Author

CFenner commented Feb 14, 2025

The label bugfix is no longer valid.

@CFenner CFenner marked this pull request as ready for review February 19, 2025 07:00
@zweckj zweckj added new-feature and removed bugfix labels Feb 19, 2025
zweckj
zweckj approved these changes Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw while checking for the docs-supported-functions I just noticed your quality scale file is missing a lot of rules

@zweckj zweckj merged commit 68085ed into home-assistant:dev Feb 19, 2025
@CFenner
Copy link
Copy Markdown
Contributor Author

CFenner commented Feb 19, 2025

Yes, I added just the one's that are fulfilled.
Is it required to list all as todo?

@zweckj
Copy link
Copy Markdown
Member

zweckj commented Feb 19, 2025

Yes, I added just the one's that are fulfilled. Is it required to list all as todo?

Yes, it's better

zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Feb 19, 2025
@CFenner @zweckj
Add sensors for pellets boiler in ViCare integration (home-assistant#…
166004b 
…138563)

* add buffer sensors

* remove duplicate sensor

* add labels

* Bump PyViCare to 2.43.0

* add fuel need sensor
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zweckj zweckj zweckj approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed integration: vicare new-feature Quality Scale: No score

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Datapoints not detected as entities.

2 participants

@CFenner @zweckj