Fix home connect coffe-milk ratio option#138593
Fix home connect coffe-milk ratio option#138593MartinHjelmare merged 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Because the The only drawback switching to select selector is that in the future, for the option entities, we should be consistent and use a select entity for that also, so we would lose the numeric graph for the entity that represents this option. |
Proposed change
Added back the functionality that I missed at ac4e1e5 which sets the coffee-milk ratio from an integer to the corresponding enum value.
Because there's a possible value
ConsumerProducts.CoffeeMaker.EnumType.CoffeeMilkRatio.67Percent, I had to lower the step to 1, and round it to 5 if it is not 67 or 68, which would set it to 67.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: