Skip to content

Fix home connect coffe-milk ratio option#138593

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Diegorro98:home_connect/fix_milk_ratio_option
Feb 15, 2025
Merged

Fix home connect coffe-milk ratio option#138593
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Diegorro98:home_connect/fix_milk_ratio_option

Conversation

@Diegorro98
Copy link
Copy Markdown
Contributor

@Diegorro98 Diegorro98 commented Feb 15, 2025

Proposed change

Added back the functionality that I missed at ac4e1e5 which sets the coffee-milk ratio from an integer to the corresponding enum value.

Because there's a possible value ConsumerProducts.CoffeeMaker.EnumType.CoffeeMilkRatio.67Percent, I had to lower the step to 1, and round it to 5 if it is not 67 or 68, which would set it to 67.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of home_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign home_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Diegorro98 Diegorro98 changed the title Fix home connect milk ratio option Fix home connect coffe-milk ratio option Feb 15, 2025
@Diegorro98
Copy link
Copy Markdown
Contributor Author

Because the ConsumerProducts.CoffeeMaker.EnumType.CoffeeMilkRatio.67Percent, I'm wondering if it is better to switch to a select selector or keep going with this solution...

The only drawback switching to select selector is that in the future, for the option entities, we should be consistent and use a select entity for that also, so we would lose the numeric graph for the entity that represents this option.
I know it is not a huge drawback but I wanted to mention it.
The pros about that is that we wouldn't need any conversion from int value to enum key.

Comment thread homeassistant/components/home_connect/__init__.py Outdated
@MartinHjelmare MartinHjelmare marked this pull request as draft February 15, 2025 11:37
@Diegorro98 Diegorro98 marked this pull request as ready for review February 15, 2025 14:43
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 78c4d81 into home-assistant:dev Feb 15, 2025
@Diegorro98 Diegorro98 deleted the home_connect/fix_milk_ratio_option branch February 15, 2025 21:16
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants