Select preferred discovered HEOS host#138779
Merged
andrewsayre merged 2 commits intodevfrom Feb 19, 2025
Merged
Conversation
70b64d5 to
591f271
Compare
591f271 to
7f39ec6
Compare
zweckj
reviewed
Feb 19, 2025
zweckj
reviewed
Feb 19, 2025
Member
Author
|
Thank you, Josef! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Modifies the HEOS discovery flow to select a preferred host (when multiple are available) and show a simple confirmation to the user to add the integration. It does this by connecting to the first discovered host, retrieving the HEOS system information, and using a method from the library to identify the preferred host. Previously, the discovery flow would accumulate all discovered hosts and then present the list to the user. This provides a much better user experience, since we can determine the best host to use automatically. The user can still manually change the host via reconfigure later. This sets the stage for being able to automatically update the host from discovery in the future. Changes are fully tested.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: