Skip to content

Select preferred discovered HEOS host#138779

Merged
andrewsayre merged 2 commits intodevfrom
heos_discovered_preferred
Feb 19, 2025
Merged

Select preferred discovered HEOS host#138779
andrewsayre merged 2 commits intodevfrom
heos_discovered_preferred

Conversation

@andrewsayre
Copy link
Copy Markdown
Member

@andrewsayre andrewsayre commented Feb 18, 2025

Proposed change

Modifies the HEOS discovery flow to select a preferred host (when multiple are available) and show a simple confirmation to the user to add the integration. It does this by connecting to the first discovered host, retrieving the HEOS system information, and using a method from the library to identify the preferred host. Previously, the discovery flow would accumulate all discovered hosts and then present the list to the user. This provides a much better user experience, since we can determine the best host to use automatically. The user can still manually change the host via reconfigure later. This sets the stage for being able to automatically update the host from discovery in the future. Changes are fully tested.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@andrewsayre andrewsayre force-pushed the heos_discovered_preferred branch from 591f271 to 7f39ec6 Compare February 18, 2025 21:59
Comment thread homeassistant/components/heos/config_flow.py
Comment thread homeassistant/components/heos/config_flow.py
Copy link
Copy Markdown
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrewsayre
Copy link
Copy Markdown
Member Author

Thank you, Josef!

@andrewsayre andrewsayre merged commit 1d3fcc6 into dev Feb 19, 2025
@andrewsayre andrewsayre deleted the heos_discovered_preferred branch February 19, 2025 17:51
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants