Fix off by one bug when sorting tasks in Habitica integration#138993
Merged
andrewsayre merged 2 commits intohome-assistant:devfrom Feb 21, 2025
Merged
Fix off by one bug when sorting tasks in Habitica integration#138993andrewsayre merged 2 commits intohome-assistant:devfrom
andrewsayre merged 2 commits intohome-assistant:devfrom
Conversation
Member
|
@tr4nt0r Do you want this to go out before the next major release? |
Contributor
Author
|
@andrewsayre it is not critical, so you can decide. I submitted it mainly as a preliminary PR for #138566 as it was suggested by @abmantis |
Member
|
@tr4nt0r OK, let's wait for the next regular release so it goes through beta testing, etc... |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes a bug were when sorting to-dos and dailies down, the task would be moved one place too far. This fixes the bug by checking if the task is to be sorted up- or downwards and using an offset of 0 if down, otherwise 1.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: