Skip to content

Fix off by one bug when sorting tasks in Habitica integration#138993

Merged
andrewsayre merged 2 commits intohome-assistant:devfrom
tr4nt0r:habitica_fix_off_by_one_bug
Feb 21, 2025
Merged

Fix off by one bug when sorting tasks in Habitica integration#138993
andrewsayre merged 2 commits intohome-assistant:devfrom
tr4nt0r:habitica_fix_off_by_one_bug

Conversation

@tr4nt0r
Copy link
Copy Markdown
Contributor

@tr4nt0r tr4nt0r commented Feb 21, 2025

Proposed change

Fixes a bug were when sorting to-dos and dailies down, the task would be moved one place too far. This fixes the bug by checking if the task is to be sorted up- or downwards and using an offset of 0 if down, otherwise 1.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r changed the title Habitica fix off by one bug Fix off by one bug when sorting tasks in Habitica integration Feb 21, 2025
Copy link
Copy Markdown
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@andrewsayre
Copy link
Copy Markdown
Member

@tr4nt0r Do you want this to go out before the next major release?

@tr4nt0r
Copy link
Copy Markdown
Contributor Author

tr4nt0r commented Feb 21, 2025

@andrewsayre it is not critical, so you can decide. I submitted it mainly as a preliminary PR for #138566 as it was suggested by @abmantis

@andrewsayre
Copy link
Copy Markdown
Member

@tr4nt0r OK, let's wait for the next regular release so it goes through beta testing, etc...

@andrewsayre andrewsayre merged commit 059a6dd into home-assistant:dev Feb 21, 2025
@tr4nt0r tr4nt0r deleted the habitica_fix_off_by_one_bug branch February 21, 2025 16:03
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants