Skip to content

Handle IPv6 URLs in devolo Home Network#139191

Merged
frenck merged 2 commits intohome-assistant:devfrom
2Fake:hn_ipv6_url
Mar 1, 2025
Merged

Handle IPv6 URLs in devolo Home Network#139191
frenck merged 2 commits intohome-assistant:devfrom
2Fake:hn_ipv6_url

Conversation

@Shutgun
Copy link
Copy Markdown
Contributor

@Shutgun Shutgun commented Feb 24, 2025

Proposed change

Sometimes the device detection discovers devolo Home Network devices via IPv6. In that case, the DeviceInfo.configuration_url causes a ValueError because the octets are treated as port. So we need to add brackets in case of IPv6.

My current setup does not have properly configured IPv6, so I'm not able to test this in a real setup ...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration (devolo_home_network) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of devolo_home_network can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign devolo_home_network Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's construct the URL using YARL, and let is handle it instead.

../Frenck

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft February 25, 2025 08:09
@Shutgun
Copy link
Copy Markdown
Contributor Author

Shutgun commented Feb 25, 2025

That was an excellent suggestion, I was not aware of. Thanks for the hint!

@Shutgun Shutgun marked this pull request as ready for review February 25, 2025 11:22
@home-assistant home-assistant Bot requested a review from frenck February 25, 2025 11:22
@frenck frenck added this to the 2025.3.0 milestone Mar 1, 2025
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Shutgun 👍

../Frenck

@frenck frenck merged commit 91eba08 into home-assistant:dev Mar 1, 2025
@Shutgun Shutgun deleted the hn_ipv6_url branch March 1, 2025 13:19
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error adding entity None for domain sensor with platform devolo_home_network

5 participants