Handle IPv6 URLs in devolo Home Network#139191
Merged
frenck merged 2 commits intohome-assistant:devfrom Mar 1, 2025
Merged
Conversation
Contributor
|
Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
CloCkWeRX
approved these changes
Feb 25, 2025
frenck
requested changes
Feb 25, 2025
Member
frenck
left a comment
There was a problem hiding this comment.
Let's construct the URL using YARL, and let is handle it instead.
../Frenck
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
Author
|
That was an excellent suggestion, I was not aware of. Thanks for the hint! |
frenck
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Sometimes the device detection discovers devolo Home Network devices via IPv6. In that case, the
DeviceInfo.configuration_urlcauses a ValueError because the octets are treated as port. So we need to add brackets in case of IPv6.My current setup does not have properly configured IPv6, so I'm not able to test this in a real setup ...
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: