Skip to content

Make Radarr unit translation lowercase#139261

Merged
joostlek merged 12 commits intohome-assistant:devfrom
danbishop:radarr-translation
Feb 25, 2025
Merged

Make Radarr unit translation lowercase#139261
joostlek merged 12 commits intohome-assistant:devfrom
danbishop:radarr-translation

Conversation

@danbishop
Copy link
Copy Markdown
Contributor

@danbishop danbishop commented Feb 25, 2025

Proposed change

Make radarr component more easily translatable

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

None

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant home-assistant Bot added cla-signed integration: radarr small-pr PRs with less than 30 lines. labels Feb 25, 2025
@home-assistant home-assistant Bot marked this pull request as draft February 25, 2025 14:29
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (radarr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of radarr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign radarr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

"queue": {
"name": "Queue",
"unit_of_measurement": "[%key:component::radarr::entity::sensor::movies::name%]"
"unit_of_measurement": "movies"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can still contain one reference :)

@danbishop danbishop marked this pull request as ready for review February 25, 2025 18:11
@joostlek joostlek changed the title Radarr translation Make Radarr unit translation lowercase Feb 25, 2025
@joostlek joostlek merged commit 7553346 into home-assistant:dev Feb 25, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 26, 2025
@joostlek
Copy link
Copy Markdown
Member

@danbishop I am not sure what exactly you are doing, but the last 2 days a ton of UK strings have been reset to [VOID]. Please check what you are doing because that is kinda breaking HA 😓. Feel free to jump in https://discord.com/channels/330944238910963714/1344366708567183361 to talk about it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants