Skip to content

Add diagnostics to fibaro integration#143003

Merged
thecode merged 3 commits intohome-assistant:devfrom
rappenze:add_diagnostics_to_fibaro_integration
Apr 16, 2025
Merged

Add diagnostics to fibaro integration#143003
thecode merged 3 commits intohome-assistant:devfrom
rappenze:add_diagnostics_to_fibaro_integration

Conversation

@rappenze
Copy link
Copy Markdown
Contributor

Proposed change

Add diagnostics to fibaro integration.
Both methods for config entry and device diagnostics are implemented.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:


from . import CONF_IMPORT_PLUGINS, FibaroConfigEntry

TO_REDACT = {"password"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we see this? I dont see this in the snapshot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right, better to cover that in a test. I appended it in the test data so now it is tested as well.

@thecode thecode merged commit 9bff88a into home-assistant:dev Apr 16, 2025
34 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2025
@rappenze rappenze deleted the add_diagnostics_to_fibaro_integration branch May 4, 2025 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants