-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
Add Universal Powerline Bus #34692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Universal Powerline Bus #34692
Conversation
Integrations with configuration flows, require a 100% coverage on at least the config flow. Please add tests 👍 |
I messed up! In getting my next PR ready I pushed the wrong thing. Trying to back out to stable. |
Thanks for not adding that to this PR. 👍 Quick note for your next PR that may save you some time: Firing custom events from entities is being phased out and won't be allowed in new code. https://developers.home-assistant.io/docs/device_automation_trigger/ may be a good option instead. |
Co-authored-by: J. Nick Koston <nick@koston.org>
Looks good. I've give it another run though after I've had some sleep. Please retest to make sure everything still works as expected. |
@gwww Everything still working ? |
Nooooo! Having problems with the |
Somewhat minor problem. Trying to figure out how to make |
You shouldn't ever see
|
It is the custom service schema that where the problem is, not the |
I need some advice. Can't figure out if this is a
When I call the service without
Functionally, the schema works correctly and catches the error I want to catch. The traceback in the |
It looks like
|
I haven't said so yet, but you have been super helpful! I really appreciate the help. Thank you. I'm would like to but I am reluctant to remove
|
Glad I could help!
https://github.com/alecthomas/voluptuous/blob/master/voluptuous/schema_builder.py#L276
If the functionality is substantially different, it is fine to have a custom service.
👍 |
Glad that I'm not the only person who gets the double exception. Should I call good enough? Nothing breaks. It validates the service call properly. The only bit it the double exception. Once this issue is clear I finish up a couple more tests and push a new commit. |
That pattern is used in a few other places including |
Update service schema to require one of brightness/brightness_pct. Fix bug in setting brightness to zero. Replace async_update_status and replace with async_update.
I just submitted the latest changes. Appears that CI is down/broken/flaky. |
/AzurePipelines Run |
Azure Pipelines successfully started running 1 pipeline(s). |
@gwww Everything still working as expected? |
All working! |
Proposed change
This is a new integration for Universal Powerline Bus (UPB).
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: