Skip to content

Include prof gem group in sorbet workflow#15134

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dduugg:sorbet-workflow
Apr 4, 2023
Merged

Include prof gem group in sorbet workflow#15134
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dduugg:sorbet-workflow

Conversation

@dduugg
Copy link
Copy Markdown
Member

@dduugg dduugg commented Apr 3, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

An attempt to fix #15119

I'm not sure how to kick off a test for this workflow, and I have issues with tapioca locally that I'm still attempting to resolve Bundler::LockfileError: You must use Bundler 2 or greater with this lockfile.)

@dduugg dduugg requested review from Bo98 and MikeMcQuaid April 3, 2023 18:45
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right to me.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit ae8fc16 into Homebrew:master Apr 4, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label May 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants