Skip to content

Fix type error when running 'brew doctor'#15744

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
dduugg:formula-type-fix
Jul 24, 2023
Merged

Fix type error when running 'brew doctor'#15744
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
dduugg:formula-type-fix

Conversation

@dduugg
Copy link
Copy Markdown
Member

@dduugg dduugg commented Jul 24, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #15730

Also addresses feedback in https://github.com/Homebrew/brew/pull/15741/files#r1271866720

@dduugg dduugg force-pushed the formula-type-fix branch from b06a4c2 to a46430a Compare July 24, 2023 14:00
@MikeMcQuaid MikeMcQuaid merged commit 4e168a1 into Homebrew:master Jul 24, 2023
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @dduugg!

@dduugg dduugg deleted the formula-type-fix branch July 24, 2023 14:42
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade with --fetch-HEAD causes internal error while fetching.

2 participants