Finalize methods that do not support overrides

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

I noticed some methods with comments discouraging overrides. Let's enforce that in code instead.

See: https://sorbet.org/docs/final

[dduugg]

Note that this method currently returns nil or T::Private::Types::Void::VOID, which is clumsy/incorrect to encode in a type signature. However, we currently have a test that relies on this being nil/non-nil depending on circumstance, so I didn't undertake a refactor. Feel free to weigh in if you want this to be resolved by other means though.

[reitermarkus]

I think this is kinda weird, since ENV#prepend_path can technically return nil masked as T::Private::Types::Void::VOID, right?

[reitermarkus]

I'd say this should always return nil, or we just remove the test and make it .void.

Probably the latter since we don't have any test/usage that uses the return value anyways.

[MikeMcQuaid]

Agreed that we should probably update the test here.

[dduugg]

I made the return type consistently void, and also updated the test to assert no error occurs (very roughly equivalent to checking for nil return, in this case).

[dduugg]

params are based on https://github.com/Homebrew/brew/blob/master/Library/Homebrew/extend/ENV.rb#L36-L39 (though I noticed that build_bottle is T.nilable(T::Boolean) in some places)

[reitermarkus]

I think T::Boolean is preferable in most cases. We should adjust the call sites to avoid T.nilable(T::Boolean) being passed where this is still the case.

[MikeMcQuaid]

@dduugg what's the latest here?

[dduugg]

@dduugg what's the latest here?

Sorry for the latency here, PTAL. I've updated the signature and test per comments.

[MikeMcQuaid]

Looks good, thanks for the quick update @dduugg!