Skip to content

Rename Formula#installed? to Formula#latest_version_installed?#6803

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:latest_version_installed
Dec 3, 2019
Merged

Rename Formula#installed? to Formula#latest_version_installed?#6803
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:latest_version_installed

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Dec 2, 2019

This naming has always been a bit weird and confusing so let's change it. It doesn't need a minor release for the deprecation because it's a private internal method and not used in Homebrew/core. It's used in Homebrew/linuxbrew-core so not making it odeprecated yet.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This naming has always been a bit weird and confusing so let's change
it and provide a `compat` fallback for later deprecation.
@MikeMcQuaid MikeMcQuaid merged commit 6decac5 into Homebrew:master Dec 3, 2019
@MikeMcQuaid MikeMcQuaid deleted the latest_version_installed branch December 3, 2019 12:09
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant