Skip to content

utils/repology.rb: fix "String can't be coerced into Integer"#8403

Merged
maxim-belkin merged 1 commit intoHomebrew:masterfrom
maxim-belkin:kwk-phx-to-s
Aug 19, 2020
Merged

utils/repology.rb: fix "String can't be coerced into Integer"#8403
maxim-belkin merged 1 commit intoHomebrew:masterfrom
maxim-belkin:kwk-phx-to-s

Conversation

@maxim-belkin
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew bump errors out with:

Error: String can't be coerced into Integer
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/utils/repology.rb:12:in `+'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/utils/repology.rb:12:in `query_api'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/utils/repology.rb:42:in `parse_api_response'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/bump.rb:41:in `bump'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:112:in `<main>'

because query_api expects a String and last_package_index is an Integer (see line 44)

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks for the quick fix!

@maxim-belkin maxim-belkin merged commit 85c0612 into Homebrew:master Aug 19, 2020
@maxim-belkin maxim-belkin deleted the kwk-phx-to-s branch August 19, 2020 19:46
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants