fix(sdk): add missing status #490 #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obazoud is attempting to deploy a commit to the Hookdeck Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a missing status field to an OpenAPI specification schema. The change addresses issue #490 by including the required status enumeration that was previously omitted from the API documentation.
- Adds a
statusfield with string type and enum values of "success" and "failed"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
leggetter
added a commit
that referenced
this pull request
Oct 13, 2025
Add missing 'status' field to Event schema in OpenAPI specification and generate updated TypeScript SDK with proper type definitions. Changes: - Updated Event schema in OpenAPI spec to include 'status' field (enum: success | failed) - Regenerated TypeScript SDK with new EventStatus type - Added comprehensive test suite for event status field validation - Updated all destination tests to use proper SDK types - Added SDK regeneration script for consistent build process The API was already returning the status field in event responses, but it was not documented in the OpenAPI spec, causing SDK clients to not have access to this field. This change aligns the spec with the actual API behavior. Tests verify: - Status field is present in events from listByDestination - Status field is present in single event retrieval - Status field is present in tenant-wide event lists - Status values are valid (success or failed) Fixes #490 Related to PR #491
|
Fix included in #518 along with a way to help us test SDKs against a running version of Outpost and identify any discrepancies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.