Merge next #143
Merged
Merge next #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: .opt-* won't be supported anymore, so formatting will always happen on pre-commit BREAKING CHANGE: Default Node compilation target is now 10.13+ BREAKING CHANGE: Updates to latest version of lint-staged which may break you if you're using a custom config for it and have `git add`
Use Prettier configuration from upstream repository (https://github.com/kentcdodds/kcd-scripts) instead of the shared configuration distributed with this package from `src/config/prettierrc.js` in order to maintain the ability to merge the upstream repo.
BREAKING CHANGE: linting TypeScript files now requires `parserOptions.project` to be specified in your ESLint configuration. If your `tsconfig.json` is at your project root, chances are you'll be fine with no changes as this project attempts to configure ESLint for that scenario. However, if you have your `tsconfig.json` elsewhere or have some other custom setup you will likely need to specify `parserOptions.project` in your `.eslintrc.json` to point at your `tsconfig.json`
BREAKING CHANGE: this enables new ESLint rules that may cause linting done with `hover-scripts lint` to start to fail
Ensure installed versions of 'eslint-plugin-react' and 'eslint-plugin-react-hooks' are compatible with 'eslint-config-airbnb'
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 86.66% 88.85% +2.19%
==========================================
Files 21 21
Lines 345 359 +14
Branches 81 86 +5
==========================================
+ Hits 299 319 +20
+ Misses 36 33 -3
+ Partials 10 7 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.