Skip to content

Build on 4.10 fails #17

@shefty

Description

@shefty

This is from Ubuntu 16.04, which is based on 4.10.

xpmem_attach.c: In function xpmem_fault_handler:
xpmem_attach.c:172:41: error: struct vm_fault has no member named virtual_address

The kernel structure vm_fault changed from 4.9 to 4.10, replacing virtual_address with address. The xpmem source traps for this >= kernel 4.11, but doesn't handle 4.10 correctly. A quick attempt to change the kernel check from 4.11 to 4.10 did not work.

4.10 needs an xpmem_fault_handler() with 2 arguments, but the vaddr pulled from vmf->address. I.e. the else check from line 162, but the if check from line 168. Trying to select this option creates a duplicate variable (vma), and it's not clear to me which one to use.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions