Skip to content

Conversation

@GordonSmith
Copy link
Member

Clean up and fix UMD stubs.

Signed-off-by: Gordon Smith gordon.smith@lexisnexis.com

Clean up and fix UMD stubs.

Signed-off-by: Gordon Smith <gordon.smith@lexisnexis.com>
@GordonSmith
Copy link
Member Author

@buunguyen Please Review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be c3_Area (lower case "c") - same goes for all the C3 charts, actually looks like you have upper-cased all the folder prefixes (which is probably ok as long as its consistent) - thoughts?

@GordonSmith
Copy link
Member Author

I suspect not prefixing the widgets in the common folder with "Common_" will potentially cause issues when it comes to writing the resolver and further down the line in namespacing. We could special case it in the root.require, but probably better to make it consistent?

@buunguyen
Copy link
Contributor

@GordonSmith you've been commenting on old commits that have been refactored several times. In HEAD, all should have prefixes and all prefixes have lowercase.

@GordonSmith
Copy link
Member Author

@buunguyen Should be correct now.

@GordonSmith GordonSmith changed the title Fix up incorrect and collided names in global scope UMD Fix Apr 19, 2015
@GordonSmith
Copy link
Member Author

@buunguyen - This looks ok to me now.

@buunguyen
Copy link
Contributor

LGTM.

GordonSmith added a commit that referenced this pull request Apr 19, 2015
@GordonSmith GordonSmith merged commit 0c7ff46 into hpcc-systems:master Apr 19, 2015
@GordonSmith GordonSmith deleted the UMD_FIX branch August 7, 2015 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants