Don't rely on device name provided by Cinder #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiall
force-pushed
the
macinnek-caps-990
branch
3 times, most recently
from
231cc0e to
5208cc6
Compare
kiall
commented
Sep 21, 2016
There was a problem hiding this comment.
FYI The above checks are already being performed, elsewhere.. These were duplicates.
kiall
force-pushed
the
macinnek-caps-990
branch
2 times, most recently
from
cc13c28 to
b3cb7bb
Compare
kiall
changed the title
xgerman
approved these changes
Sep 21, 2016
See issue kubernetes#33128 We can't rely on the device name provided by Cinder, and thus must perform detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. This patch re-works the cinder volume attacher (the parts executed in kube-controller-manager) to return the volume ID, rather than the device name as advertised by Cinder. We then rework the cinder volume attacher (this time, the parts executed in kubelet) to accept this ID, and call the pre-existing GetDevicePath method, will will perform the discovery correctly. This is a break in the Attacher interface, which explicitly calls for the Attach method to return a device name.
kiall
force-pushed
the
macinnek-caps-990
branch
from
b3cb7bb to
3763783
Compare
kiall
changed the title
|
Upstream patch has changed, hold off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue kubernetes#33128
We can't rely on the device name provided by Cinder, and thus must perform
detection based on the drive serial number (aka It's cinder ID) on the
kubelet itself.
This patch re-works the cinder volume attacher (the parts executed in
kube-controller-manager) to return the volume ID, rather than the device
name as advertised by Cinder. We then rework the cinder volume attacher
(this time, the parts executed in kubelet) to accept this ID, and call the
pre-existing GetDevicePath method, will will perform the discovery
correctly.
This is a break in the Attacher interface, which explicitly calls for the
Attach method to return a device name.