-
-
Notifications
You must be signed in to change notification settings - Fork 281
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
Using themed components results in deprecation warnings from @Material (e.g. Using / for division is deprecated). This can be fixed by upgrading to the latest version of @Material (as of writing, that means upgrading from 11 to 12).
To Reproduce
Steps to reproduce the behavior:
- Create a new Svelte project
npx degit sveltejs/template my-svelte-project`)
- Install smui/button
npm install --save @smui/button
- Go through the steps for the Advanced Styling Method
a.npm install --save-dev sass rollup-plugin-postcss
b. Add sass to your rollup config
c. Add a blank_smui-theme.scssfile (this prevents a compilation error, but it doesn't need any code in it) - Add a styled button to your App component:
<script>
import Button from '@smui/button/styled';
</script>
<Button>Hello</Button>npm run devwill result in deprecation warnings
Additional context
I've only tested this with Button, but manually installing the latest version of the material dependencies fixed the issue. E.g. installing
"@material/button": "^12.0.0",
"@material/elevation": "^12.0.0",
"@material/feature-targeting": "^12.0.0",
"@material/ripple": "^12.0.0",
"@material/theme": "^12.0.0",
But given how many components there are, I wouldn't be surprised if others required more adjustments to work with the newer version of material.
urbiconwbadart and Egnus
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
