Small clarification in the 'Advanced OO' slides

[Ban42]

Hi everyone,
Was having a look at the 'Advanced OO' slides and found some small things that IMHO could be clarified.

In slide 136 (full course file) it is written that

the virtual method keyword is then optional

I believe it should be turned into

the virtual method keyword is then optional in the derived classes

As an new user may mistakenly understand that by using the override keyword in a derived class they can omit the virtual keyword in the base class.

In slide 137 (full course file) it is written that:

if you forget override when you should have it, you get a compiler warning

I would turn it into:

if you forget override when you should have it, you may get a compiler warning

Since I am using g++ 11.5.0 with -Wall and I don't get any warning.

I can make the changes myself in a MR, just wanted to create a issue first and double-check if you approve the changes.

Thanks.

[hageboeck]

Hello @Ban42,

these comments make a lot of sense, thank you!

I was already implementing your suggestions until I read the line that you could do the MR yourself. Sorry, I was a bit too fast, but I credited you as the person that notified us. OK like that?

[Ban42]

Hi @hageboeck ,
No worries at all. Next time I will open a PR myself :)