#14 adds new rule section-has-heading #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balesniy
approved these changes
Jul 8, 2023
Contributor
balesniy
left a comment
balesniy
left a comment
There was a problem hiding this comment.
можно из этого утилитку сделать на будущее типа return node.children.some(checkChildNode) чтобы всякое произвольное искать в потомках
balesniy
suggested changes
Jul 9, 2023
rules/section-has-heading/index.js
Outdated
| return true; | ||
| } | ||
|
|
||
| if (node.children) { |
Contributor
There was a problem hiding this comment.
я подумал, что тут нам нужна проверка на svg чтобы в них не искать заголовки
Contributor
Author
There was a problem hiding this comment.
Хорошая идея. Добавил проверку
balesniy
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пока решил проверять также h1 в секцияъ, что легко поправить если что.
И думаю, что если мы захотим учитывать правило, что в
<section>не может быть<h1>, то сделать это отдельным правилом