Skip to content

Conversation

@coliff
Copy link
Member

@coliff coliff commented Nov 30, 2025

Changed VSCode Prettier extension to 'prettier.prettier-vscode' and updated Prettier dependency to version 3.7.3. Also refined the Prettier script to target specific file types for formatting.

Changed VSCode Prettier extension to 'prettier.prettier-vscode' and updated Prettier dependency to version 3.7.3. Also refined the Prettier script to target specific file types for formatting.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Prettier VS Code extension to the official one, bumps the Prettier dependency to a newer patch version, and refines the Prettier npm script. The changes are generally good and improve project maintenance. I've found one area for improvement in the package.json file where the Prettier script's file glob could be more comprehensive to include all relevant file types in the project, such as TypeScript and HTML files. I've left a specific suggestion to address this.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (95e6a13) to head (b1ef932).
⚠️ Report is 179 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1774      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b4b42...b1ef932. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot finished reviewing on behalf of coliff November 30, 2025 05:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Prettier tooling configuration by switching from the deprecated esbenp.prettier-vscode extension to the official prettier.prettier-vscode extension, upgrades Prettier from version 3.7.0 to 3.7.3, and refines the prettier script to explicitly target specific file types instead of formatting all files.

  • Updated VSCode Prettier extension identifier to the official extension
  • Upgraded Prettier dependency from 3.7.0 to 3.7.3
  • Modified prettier script to explicitly list file types for formatting

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updated Prettier version to 3.7.3 and refined prettier script with explicit file type patterns
package-lock.json Updated Prettier package lock entries to match version 3.7.3
.vscode/settings.json Changed default formatter to official Prettier extension identifier
.vscode/extensions.json Updated recommended extension to official Prettier extension

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

Deploying htmlhint with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1ef932
Status:⚡️  Build in progress...

View logs

@coliff coliff merged commit 4ca90ca into main Nov 30, 2025
5 of 7 checks passed
@coliff coliff deleted the dev/coliff/prettier-update branch November 30, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants