Skip to content

Conversation

@coliff
Copy link
Member

@coliff coliff commented Jun 11, 2025

  • Old: vscode-languageclient@3.5.1 & vscode-languageserver@3.5.1
  • New: vscode-languageclient@9.0.1 & vscode-languageserver@9.0.1

What was fixed:
✅ Dependencies: Updated all LSP packages to version 9.x
✅ Breaking Changes: Fixed all API changes (imports, connection setup, TextDocuments, etc.)
✅ Missing Dependencies: Added vscode-languageserver-textdocument@^1.0.12
✅ Extension Configuration: Fixed activation events to be more specific
✅ Build Process: Updated bundle-dependencies script
✅ Code Quality: Removed deprecated APIs and modernized the codebase

Benefits you'll get from LSP 9.x:
🚀 Better Performance: More efficient client-server communication
🔧 Modern APIs: Access to latest Language Server Protocol features
🛡️ Better Error Handling: Improved debugging and error reporting
🔄 Future-Proof: Ongoing support and updates
📊 Enhanced Diagnostics: Better linting feedback

The extension should now work faster and more reliably with HTML files, providing the same great HTMLHint linting experience with the modern LSP infrastructure underneath

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the Language Server Protocol (LSP) dependencies to version 9.x, addressing breaking API changes, missing dependencies, extension configuration, and build processes. The update aims to improve performance, provide access to modern APIs, enhance error handling, and ensure future support.

Comment on lines +281 to +285
// Convert URI to file path manually since Files API is not available
let fsPath = uri.replace(/^file:\/\//, "");
if (process.platform === "win32" && fsPath.startsWith("/")) {
fsPath = fsPath.substring(1);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider extracting the platform-specific path conversion to a separate function for better readability and maintainability.

    let uri = document.uri;
    // Convert URI to file path manually since Files API is not available
    let fsPath = uri.replace(/^file:\/\//, "");
    if (process.platform === "win32" && fsPath.startsWith("/")) {
      fsPath = fsPath.substring(1);
    }

Comment on lines +2786 to 2791
"version": "8.2.0",
"resolved": "https://registry.npmjs.org/vscode-jsonrpc/-/vscode-jsonrpc-8.2.0.tgz",
"integrity": "sha512-C+r0eKJUIfiDIfwJhria30+TYWPtuHJXHtI7J0YlOmKAo7ogxP20T0zxB7HZQIFhIyvoBPwWskjxrvAtfjyZfA==",
"engines": {
"node": ">=4.0.0 || >=6.0.0"
"node": ">=14.0.0"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The engine constraint has been updated. Ensure that this change aligns with the project's supported Node.js versions.

    "node_modules/vscode-jsonrpc": {
      "version": "8.2.0",
      "resolved": "https://registry.npmjs.org/vscode-jsonrpc/-/vscode-jsonrpc-8.2.0.tgz",
      "integrity": "sha512-C+r0eKJUIfiDIfwJhria30+TYWPtuHJXHtI7J0YlOmKAo7ogxP20T0zxB7HZQIFhIyvoBPwWskjxrvAtfjyZfA==",
      "engines": {
        "node": ">=14.0.0"

@coliff coliff merged commit 403905c into main Jun 11, 2025
9 checks passed
@coliff coliff deleted the dev/coliff/update-lang-server-protocol branch June 11, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants