Replace vscode-test with @vscode/test-electron #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project from the deprecated vscode-test package to @vscode/test-electron. The dependency updates across package.json and package-lock.json files, along with the corresponding import change in runTest.ts, are correct. The move of project rules to AGENTS.md and the update of repository URLs are also good improvements. I have identified a minor configuration error in .npmrc and a couple of small improvements for the new AGENTS.md file.
The 'ignore' package has been removed from the dependencies in both htmlhint and htmlhint-server. This reduces the number of dependencies and may improve maintainability if the package is no longer needed. Replace vscode-test with @vscode/test-electron Migrated from the deprecated vscode-test package to @vscode/test-electron in all relevant package files and test scripts. Updated .npmrc with additional settings, removed an obsolete .cursor rules file, and added AGENTS.md with project guidelines. Also updated repository URLs to use the git+https format. Add 'ignore' package as a dependency Added the 'ignore' package (version ^7.0.5) to dependencies in package.json to support file ignoring functionality. Update .npmrc Add build script to package.json Introduced a 'build' script that runs 'npm run compile' in package.json to streamline the build process. Minor whitespace adjustment in dependabot.yml for consistency. Update .npmrc
coliff
force-pushed
the
dev/coliff/use-vscode-test-electron
branch
from
7bc2589 to
21ec1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from the deprecated vscode-test package to @vscode/test-electron in all relevant package files and test scripts. Updated .npmrc with additional settings, removed an obsolete .cursor rules file, and added AGENTS.md with project guidelines. Also updated repository URLs to use the git+https format.