Migrate ESLint config to flat config and update deps #338
+667
−697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces .eslintrc.js with eslint.config.js using the new flat config format. Updates ESLint and TypeScript ESLint dependencies to latest major versions, adjusts ignore patterns, and refactors htmlhint-server code to use unused parameter conventions. Also bumps VS Code engine and type dependencies for compatibility.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the ESLint configuration to the new flat config format and updates related dependencies. The code changes to handle unused variables are correct. I've identified a potential conflict in the new ESLint configuration regarding the no-unused-vars rule for TypeScript files and have also provided suggestions to simplify the globals configuration for better maintainability.
Added 'tsparser' to the cspell dictionary. Modified ESLint config to disable the base 'no-unused-vars' rule for TypeScript files and removed its custom configuration to prevent rule conflicts.
Replaces manual Node.js global definitions in eslint.config.js with the globals package for improved maintainability. Adds 'globals' as a dev dependency in package.json and updates its version in package-lock.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eslintrc.jswitheslint.config.jsusing the new flat config format.