Add autofix for attr-value-no-duplication rule
#339
Merged
+176
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented auto-fix logic for the attr-value-no-duplication rule in the server, which removes duplicate values within attribute values. Updated documentation and changelog, and added new test cases for both attr-no-duplication and attr-value-no-duplication rules.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an auto-fix for the attr-value-no-duplication rule, along with documentation updates and new test cases for both attr-no-duplication and attr-value-no-duplication. The implementation is solid, but I've found a potential issue in the auto-fix logic that could lead to fixing the wrong attribute in some edge cases. I've also suggested a minor change in the README to maintain alphabetical order. Overall, great work on expanding the auto-fix capabilities!
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented auto-fix logic for the attr-value-no-duplication rule in the server, which removes duplicate values within attribute values.
Updated documentation and changelog, and added new test cases for both attr-no-duplication and attr-value-no-duplication rules.