Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

outcatcher
Copy link

What this PR does / why we need it:
Required for implementing terraform-providers/terraform-provider-opentelekomcloud#512

Special notes for your reviewer:
Implementation of retry for API call requires configuring client additionally. Now maxRetries set to non-default value only when using NewClient method

Release note:

NONE

@coveralls
Copy link

coveralls commented Jul 8, 2020

Pull Request Test Coverage Report for Build 821

  • 23 of 36 (63.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/client.go 4 6 66.67%
provider_client.go 19 30 63.33%
Totals Coverage Status
Change from base Build 812: 0.02%
Covered Lines: 11532
Relevant Lines: 16835

💛 - Coveralls

@outcatcher
Copy link
Author

Will implement it as done in https://github.com/terraform-providers/terraform-provider-openstack/pull/413/files#diff-d19ac55950aaa9524c5843a2182fe77e ― this doesn't require changes in SDK

@outcatcher outcatcher closed this Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants