This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Add MAASV1 client #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // MAASV1 creates a ServiceClient that may be used with the v1 MAAS service. | ||
| func MAASV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| sc, err := initClientOpts(client, eo, "network") | ||
| sc.Endpoint = strings.Replace(sc.Endpoint, "vpc", "maas", 1) |
There was a problem hiding this comment.
can the MaaS endpoint be found in catalog list?
There was a problem hiding this comment.
There's already a NewMAASV1 for that in the catalog list, but we can't find the endpoint in HuaweiCloud :( So added this MAASV1 as a workaround.
Pull Request Test Coverage Report for Build 303
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: