Fix CI issues #1063
Merged
Fix CI issues #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are required by spotless starting JDK 16+
This is needed to inject the unsupported HTTP verb. I don't know really if we will be able to find a better option than that...
It might be possible to make them work again but it will require some more advanced surgery.
Contributor
Author
|
@bitwiseman looks like you will need to adjust the Expected statuses if we want to get this in :). |
bitwiseman
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the CI issues with JDK 16+.
The detail is in each commit. There's a good chance things will need proper fixes but at least we can have a green CI until workarounds are found.
For the record, I pass the options for JDK 11+ as they are needed but not required for JDK 11.
For now, I haven't added 17-ea as Findbugs' ASM version doesn't like it yet.