-
Notifications
You must be signed in to change notification settings - Fork 769
(refactor) Replace complex parsing logic from GHEvent.type to GHEvent with static mapping #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with static mapping [hub4j#1099]
Codecov Report
@@ Coverage Diff @@
## main #1126 +/- ##
============================================
+ Coverage 73.14% 73.26% +0.11%
Complexity 1824 1824
============================================
Files 185 185
Lines 6100 6116 +16
Branches 368 365 -3
============================================
+ Hits 4462 4481 +19
+ Misses 1417 1416 -1
+ Partials 221 219 -2
Continue to review full report at Codecov.
|
bitwiseman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what I was expecting, but it works, is clearer, and it has to be faster than the old way.
Minor changes needed.
bitwiseman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use EnumUtils t hat would be better.
304d609 to
5c64fec
Compare
|
Thanks for making the changes. I believe everything is resolved now and is good to merge? |
|
@akashRindhe |
No issues mate. Cheers :) |
#1099
Description
Replace complex parsing logic from GHEvent.type to GHEvent with static mapping