-
Notifications
You must be signed in to change notification settings - Fork 769
Add getAppInstallations(/user/installations) method on GHMyself #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1187 +/- ##
============================================
+ Coverage 73.82% 73.85% +0.02%
- Complexity 1856 1862 +6
============================================
Files 186 188 +2
Lines 6163 6181 +18
Branches 367 368 +1
============================================
+ Hits 4550 4565 +15
- Misses 1392 1395 +3
Partials 221 221
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t0m4uk1991
Thanks for your continued contributions!
You've tested this for 1 installation and it works fine, but ...
This is actually a paged response. Similar to search and a number of other endpoints
https://docs.github.com/en/rest/reference/apps#list-app-installations-accessible-to-the-user-access-token--parameters
😭
You'll need to implement this using a class extending PagedIterable in about the same way https://github.com/hub4j/github-api/blob/main/src/main/java/org/kohsuke/github/PagedSearchIterable.java does.
93343a4 to
81ac480
Compare
|
Hi @bitwiseman Thanks for quick feedback. Thanks |
Description
Add getAppInstallations (under the hood call on /user/installations) method in GHMyself
For more info pls take a look at https://docs.github.com/en/rest/reference/apps#list-app-installations-accessible-to-the-user-access-token