Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #576 collaborator by username #1431

merged 8 commits into from Aug 18, 2022


Copy link

@0xacx 0xacx commented Apr 12, 2022


Fixes #576
Adds a method to check if GHUser is a collaborator on that repository. You can find the github documentation for that endpoint here.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@0xacx 0xacx changed the title Issue 576 collaborator by username Fix Issue #576 collaborator by username Apr 12, 2022
Copy link
Contributor Author

0xacx commented Apr 14, 2022

@bitwiseman Could I please have access to the test org so I can record the response for the wiremock stub?
Thank you!

Copy link

@0xacx Invitation sent.

Copy link
Contributor Author

0xacx commented May 19, 2022

@bitwiseman Unfortunately I haven't logged in for a long while and the invitation expired. Any chance you could resend it?

Copy link

@0xacx Sent invite again.

Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1431 (be1aaa5) into main (262cf84) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1431      +/-   ##
- Coverage     78.81%   78.80%   -0.01%     
- Complexity     2114     2115       +1     
  Files           202      202              
  Lines          6429     6432       +3     
  Branches        361      362       +1     
+ Hits           5067     5069       +2     
  Misses         1152     1152              
- Partials        210      211       +1     
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/ 68.92% <66.66%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor Author

0xacx commented Jul 20, 2022

@bitwiseman Could you or any other maintainer please approve running the workflows? Thanks!

Copy link
Contributor Author

0xacx commented Jul 21, 2022

@bitwiseman The Java 8 build is failing at the codecov job, because of an expired certificate. It looks random to me, as if it was indeed expired, all branches should suffer from that. Could we try a rerun or is there something else I should do?

Copy link

Nothing for you to do right now. I'll get it fixed up and rerun.

@bitwiseman bitwiseman merged commit 49982a2 into hub4j:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Does the github api support getting a collaborator by username?
2 participants