Skip to content

Conversation

@bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Feb 22, 2020

User reported #708 which made me realize that issue search tests were basically all disabled.
This terms on two basic search tests and also makes it so GHIssue can continue to work without
a GHRepository set on it.

Fixes #708

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

@bitwiseman bitwiseman force-pushed the issue/708 branch 2 times, most recently from 0e97e3d to 4edecbf Compare February 22, 2020 02:30
User reported hub4j#708 which made me realize that search tests were basically all disabled.
This terms on two basic search tests and also makes it so GHIssue can continue to work without
a GHRepository set on it.

Fixes hub4j#708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GHssue.listComments() throws NullPointer from search result - owner not set

1 participant