Use InjectableValue to provide response info #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
force-pushed
the
task/inject-response
branch
2 times, most recently
from
73d3c6c to
9d7e796
Compare
bitwiseman
force-pushed
the
task/inject-response
branch
from
9d7e796 to
f8c2cda
Compare
bitwiseman
commented
Feb 25, 2020
| * @param <T> | ||
| * type of the object | ||
| */ | ||
| private static <T> void setResponseHeaders(GitHubResponse.ResponseInfo responseInfo, T readValue) { |
Member
Author
There was a problem hiding this comment.
This is the special case code that we had before.
bitwiseman
commented
Feb 25, 2020
| * the {@link GitHubResponse.ResponseInfo} to get headers from. | ||
| */ | ||
| @JacksonInject | ||
| protected void setResponseHeaderFields(@CheckForNull GitHubResponse.ResponseInfo responseInfo) { |
Member
Author
There was a problem hiding this comment.
This is what we do instead of the special case.
bitwiseman
commented
Feb 25, 2020
| Record(@JsonProperty(value = "limit", required = true) int limit, | ||
| @JsonProperty(value = "remaining", required = true) int remaining, | ||
| @JsonProperty(value = "reset", required = true) long resetEpochSeconds, | ||
| @JacksonInject @CheckForNull GitHubResponse.ResponseInfo responseInfo) { |
Member
Author
There was a problem hiding this comment.
Also, since we now have the the responseInfo injected during binding, we can make Record fully immutable. We don't have "recalculate" after creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jackson can do binding of injected values for us rather than needing to special case them.
A continuation of this change would be to remove most of the initialization
wrapUp(root)methods and add a binding forGitHubmember.Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.