Retrieve html_url from Pull Request Review Comment #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
reviewed
Mar 17, 2020
| assertEquals("Sample review comment", comment.getBody()); | ||
|
|
||
| // Assert htmlUrl is not null | ||
| assertNotNull(comment.getHtmlUrl()); |
Member
There was a problem hiding this comment.
Needs to be more than non-null.
Contributor
Author
There was a problem hiding this comment.
We need to check for more than just non-null. What value should it be?
It's actually a dynamically determined URL something along of the lines of this : https://github.com/apache/flink/pull/5862#discussion_r184057665
Member
There was a problem hiding this comment.
@sladyn98
But it is recorded so it won't change after that.
Contributor
Author
There was a problem hiding this comment.
Yep, another test upcoming :)
bitwiseman
reviewed
Mar 17, 2020
Member
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
We need to check for more than just non-null. What value should it be?
bitwiseman
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is used to retrieve the
html_urlfrom a Pull Request Review Comment instead of returning nullCloses : #736
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those chxanges. If this command doesn't succeed, your change will not pass CI.