Allow "refs/" prefix in parameter to GHRepository.getRef() #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There is a CI failure about "addCollaborators". From the log:
I don't think I've changed this method, though. |
bitwiseman
reviewed
Apr 5, 2020
| @@ -1,25 +0,0 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
@martinvanzijl It looks like you modified the test resources for this, whether you meant to or not. This would be where the error is coming from.
Contributor
Author
There was a problem hiding this comment.
@bitwiseman Sorry, my mistake. Should be fixed now.
bitwiseman
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows having the "refs/" prefix in parameter to
GHRepository.getRef(). This is optional, so "refs/heads/master" will work, as well as "heads/master".Fixes #518.