Modified datasets/prov-info and samples/prov-info to check the size o… #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the returned json before returning. If it is at (or near) the max for AWS, return a 400 prompting the user to apply some optional parameters to reduce the size. Changed the date values in datasets/prov-info and datasets/<id>/prov-info by converting them to strings from datetime objects. While they were datetime objects, they weren't valid json, so dumping to json would result in a 500.
yuanzhou
requested changes
Jan 31, 2023
src/app.py
Outdated
| # is greater than 9MB Return a 400 and prompt the user to reduce the size of the output by applying optional | ||
| # argument filters. | ||
| dataset_prov_json_encode = json.dumps(dataset_prov_list).encode('utf-8') | ||
| if len(dataset_prov_json_encode) > 9000000: |
Member
There was a problem hiding this comment.
Let's keep it consistent by using 9*(2**20) (9437184) rather than 9000000 https://github.com/hubmapconsortium/uuid-api/blob/main/src/instance/app.cfg.example#L35 which is closer to 10MB. Also update the comment.
src/app.py
Outdated
| # is greater than 9MB Return a 400 and prompt the user to reduce the size of the output by applying optional | ||
| # argument filters. | ||
| sample_prov_json_encode = json.dumps(sample_prov_list).encode('utf-8') | ||
| if len(sample_prov_json_encode) > 9000000: |
yuanzhou
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified datasets/prov-info and samples/prov-info to check the size of the
returned json before returning. If it is at (or near) the max for AWS,
return a 400 prompting the user to apply some optional parameters to reduce
the size. Changed the date values in datasets/prov-info and
datasets//prov-info by converting them to strings from datetime
objects. While they were datetime objects, they weren't valid json, so
dumping to json would result in a 500.