Verify value is defined before trying to run a min/max length value.#240
Merged
hueitan merged 1 commit intohueitan:masterfrom Oct 14, 2016
Merged
Verify value is defined before trying to run a min/max length value.#240hueitan merged 1 commit intohueitan:masterfrom
hueitan merged 1 commit intohueitan:masterfrom
Conversation
this will help avoid a TypeError.
2 similar comments
Owner
|
Sorry for the late review, Thanks for fixing the issue. 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will help avoid a TypeError when no value is entered and min length/max length validators are used.