Skip to content

Conversation

ydshieh
Copy link
Contributor

@ydshieh ydshieh commented Sep 13, 2022

Fix #482.

Up up!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward change. It seems to work for me. And I think this does have test coverage in test_layers_utils, which is passing. 👍

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slow tests are all passing - checked locally. Looks good to me!

@patrickvonplaten patrickvonplaten merged commit c049372 into huggingface:main Sep 16, 2022
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Fix PT up/down sample_2d

* empty commit

* style

* style

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some methods mix the usage of numpy and torch
4 participants