Skip to content

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Dec 4, 2023

Context: internal slack msg

To get model status, GET request https://api-inference.huggingface.co/status/{MODEL-ID} is used to check status of a model on hf inference api.

This PR makes it so that only when a model.inference is InferenceDisplayability.Yes, get the model status.

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 (conceptual LGTM)

@mishig25 mishig25 merged commit 730fe4a into main Dec 5, 2023
@mishig25 mishig25 deleted the get_model_status_oninfyes branch December 5, 2023 09:52
@julien-c
Copy link
Member

julien-c commented Dec 5, 2023

i think it's useful if we wait for a @SBrandeis review (even a quick glance one) for widget-related things from now on. Ok for everyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants