Skip to content

[Widget] get model status only on InferenceDisplayability.Yes models #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[Widget] get model status only on InferenceDisplayability.Yes models #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18ed59
[Widget] get model status only on `InferenceDisplayability.Yes` models
mishig25 Dec 4, 2023
8489809
format
mishig25 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 47 additions & 43 deletions ...ages/widgets/src/lib/components/InferenceWidget/shared/WidgetWrapper/WidgetWrapper.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,17 @@

onMount(() => {
(async () => {
modelLoadInfo = await getModelLoadInfo(apiUrl, model.id, includeCredentials);
$modelLoadStates[model.id] = modelLoadInfo;
modelTooBig = modelLoadInfo?.state === "TooBig";
if (model.inference === InferenceDisplayability.Yes) {
modelLoadInfo = await getModelLoadInfo(apiUrl, model.id, includeCredentials);
$modelLoadStates[model.id] = modelLoadInfo;
modelTooBig = modelLoadInfo?.state === "TooBig";

if (modelTooBig) {
// disable the widget
isDisabled = true;
inputSamples = allInputSamples.filter((sample) => sample.output !== undefined);
inputGroups = getExamplesGroups();
if (modelTooBig) {
// disable the widget
isDisabled = true;
inputSamples = allInputSamples.filter((sample) => sample.output !== undefined);
inputGroups = getExamplesGroups();
}
}

const exampleFromQueryParams = {} as TWidgetExample;
Expand Down Expand Up @@ -110,42 +112,44 @@
<WidgetHeader pipeline={model.pipeline_tag} noTitle={true} />
<WidgetInfo {model} {computeTime} {error} {modelLoadInfo} {modelTooBig} />
{:else}
<div
class="flex w-full max-w-full flex-col
{isMaximized ? 'fixed inset-0 z-20 bg-white p-12' : ''}
{!modelLoadInfo ? 'hidden' : ''}"
>
{#if isMaximized}
<button class="absolute right-12 top-6" on:click={() => (isMaximized = !isMaximized)}>
<IconCross classNames="text-xl text-gray-500 hover:text-black" />
</button>
{/if}
<WidgetHeader {noTitle} pipeline={model.pipeline_tag} {isDisabled}>
{#if !!inputGroups.length}
<div class="ml-auto flex gap-x-1">
<!-- Show samples selector when there are more than one sample -->
{#if inputGroups.length > 1}
<WidgetInputSamplesGroup
bind:selectedInputGroup
<!-- require that we have `modelLoadInfo` for InferenceDisplayability.Yes models -->
{#if modelLoadInfo || model.inference !== InferenceDisplayability.Yes}
<div
class="flex w-full max-w-full flex-col
{isMaximized ? 'fixed inset-0 z-20 bg-white p-12' : ''}"
>
{#if isMaximized}
<button class="absolute right-12 top-6" on:click={() => (isMaximized = !isMaximized)}>
<IconCross classNames="text-xl text-gray-500 hover:text-black" />
</button>
{/if}
<WidgetHeader {noTitle} pipeline={model.pipeline_tag} {isDisabled}>
{#if !!inputGroups.length}
<div class="ml-auto flex gap-x-1">
<!-- Show samples selector when there are more than one sample -->
{#if inputGroups.length > 1}
<WidgetInputSamplesGroup
bind:selectedInputGroup
{isLoading}
inputGroups={inputGroups.map(({ group }) => group)}
/>
{/if}
<WidgetInputSamples
classNames={!selectedInputSamples ? "opacity-50 pointer-events-none" : ""}
{isLoading}
inputGroups={inputGroups.map(({ group }) => group)}
inputSamples={selectedInputSamples?.inputSamples ?? []}
{applyInputSample}
/>
{/if}
<WidgetInputSamples
classNames={!selectedInputSamples ? "opacity-50 pointer-events-none" : ""}
{isLoading}
inputSamples={selectedInputSamples?.inputSamples ?? []}
{applyInputSample}
/>
</div>
</div>
{/if}
</WidgetHeader>
<slot name="top" {isDisabled} />
<WidgetInfo {model} {computeTime} {error} {modelLoadInfo} {modelTooBig} />
{#if modelLoading.isLoading}
<WidgetModelLoading estimatedTime={modelLoading.estimatedTime} />
{/if}
</WidgetHeader>
<slot name="top" {isDisabled} />
<WidgetInfo {model} {computeTime} {error} {modelLoadInfo} {modelTooBig} />
{#if modelLoading.isLoading}
<WidgetModelLoading estimatedTime={modelLoading.estimatedTime} />
{/if}
<slot name="bottom" />
<WidgetFooter bind:isMaximized {outputJson} {isDisabled} />
</div>
<slot name="bottom" />
<WidgetFooter bind:isMaximized {outputJson} {isDisabled} />
</div>
{/if}
{/if}