-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for multi-label classification #14168
Add documentation for multi-label classification #14168
Conversation
I don't think this is the right way to fix it: the docstring you have written is great, but it should be added in the base sequence classification docstring, as all models with a sequence classification head should accept |
Thanks @sgugger ! Sure - by the "base sequence classification docstring" you mean this? Happy to help you fixing the models that do not currently support |
Yes, I meant that docstring. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
4f1dd9b
to
8ddbfe9
Compare
4f1dd9b
to
5bfdc77
Compare
Hi @sgugger, Modified as suggested - hope this helps. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adapting it, it's much better this way!
What does this PR do?
Works toward fixing #9772
The
problem_type="multi_label_classification"
in PretrainedConfig exist for many models; however, I added documentation for DistilBert only for now. If what I've done so far looks good, I'll add the same to the remaining models; otherwise I need some guidance.Also, I have added a notebook with a full example in huggingface/notebooks#102
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
@LysandreJik and @sgugger may be interested in this review.