-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torch 1.10 #14169
Torch 1.10 #14169
Conversation
As a side note. I'm excited that label smoothing is now integrated into cross entropy! https://pytorch.org/docs/stable/generated/torch.nn.CrossEntropyLoss.html Excited to replace my current implementation with this. |
4f40c9c
to
c162808
Compare
@anton-l @patrickvonplaten @Narsil there's the following error when passing to torch 1.10:
Do you know where it might come from? |
@LysandreJik I can't track down which commit made the outputs different yet. The checkpoint certainly didn't change. Is it only torch 1.10 that gets affected? |
It seems so! |
c162808
to
04a1ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this upgrade!
* Torch 1.10 * torch scatter for 1.10 * style * Skip tests ok
Authorize torch 1.10