Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify QA examples #14172

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Oct 27, 2021

What does this PR do?

It clarifies a bit the difference between the various example scripts for question-answering. It also removes some of the things related to the legacy scripts (which were still included in the README) to the legacy folder.

Related to #14170

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those better!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this @NielsRogge!

@NielsRogge NielsRogge merged commit 7396095 into huggingface:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants