Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline tests env and fetch #14209

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix pipeline tests env and fetch #14209

merged 2 commits into from
Oct 29, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Oct 29, 2021

What does this PR do?

This PR fixes two things:

  • changing pipelines/base.py should run all pipeline tests in the test fetcher
  • the pipelines test do not install the timm extra dependency, and thus skip the image segmentation tests.

@sgugger sgugger requested review from Narsil and LysandreJik October 29, 2021 13:06
LysandreJik
LysandreJik approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it, @sgugger! LGTM

@sgugger sgugger merged commit 4ab6a4a into master Oct 29, 2021
@sgugger sgugger deleted the pipeline_tests branch October 29, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@Narsil Narsil Awaiting requested review from Narsil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgugger @LysandreJik