Update Transformers to huggingface_hub >= 0.1.0 #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
commented
Nov 2, 2021
Comment on lines
-1412
to
+1416
| expected_commits = [f"Training in progress, step {i}" for i in range(20, 0, -5)] | ||
| total_steps = 20 // num_gpus | ||
| expected_commits = [f"Training in progress, step {i}" for i in range(total_steps, 0, -5)] |
There was a problem hiding this comment.
This is the test that was failing on multi-GPU
LysandreJik
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Nice, welcome cleanup! Thank you for taking care of that @sgugger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the minimum version of huggingface_hub to 0.1.0 and makes all the simplifications related to
HfApimethods being exposed as functions.Note that some of the commands that relied on the old HfApi were failing since the switch a few versions ago but no issue was opened. This PR removes the code and just returns a somewhat helpful error message.
This PR also fixes one push_to_hub test for the Trainer, currently failing if there are several GPUs.