Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Keras cause they messed their release #14262

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Pin Keras cause they messed their release #14262

merged 4 commits into from
Nov 3, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 3, 2021

What does this PR do?

The title is self-explanatory

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sgugger

setup.py Outdated
@@ -107,6 +107,7 @@
"jax>=0.2.8",
"jaxlib>=0.1.65",
"jieba",
"keras<2.7.0", # Remove when they fix their release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said offline, proposal

Suggested change
"keras<2.7.0", # Remove when they fix their release
"keras!=2.7.0", # Remove when they fix their release

@sgugger sgugger merged commit a1c15ea into master Nov 3, 2021
@sgugger sgugger deleted the pin_keras branch November 3, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants