Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mutable default argument in pipeline. #14316

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Nov 8, 2021

What does this PR do?

Fixes #14292

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! Thank you for taking care of it @Narsil

@Narsil Narsil force-pushed the fix_mutable_default branch from c8ee664 to 61d4bb3 Compare November 8, 2021 14:51
This reverts commit 61d4bb3.
@Narsil Narsil merged commit a3ded17 into huggingface:master Nov 8, 2021
@Narsil Narsil deleted the fix_mutable_default branch November 8, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutable default value for model_kwargs in pipeline function
2 participants