Adding some quality of life for pipeline function.
#14322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
force-pushed
the
qol_pipeline_magic
branch
from
f62f1c5 to
3cfcdf3
Compare
Narsil
force-pushed
the
qol_pipeline_magic
branch
from
3cfcdf3 to
f13cf26
Compare
Narsil
requested review from
LysandreJik and
sgugger
and removed request for
LysandreJik
sgugger
approved these changes
Nov 9, 2021
| @require_torch | ||
| def test_check_task_auto_inference(self): | ||
| pipeline(model="Narsil/tiny-distilbert-sequence-classification") | ||
|
|
There was a problem hiding this comment.
Can we check that the result has the right type?
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
|
I'll merge ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two quality of life things on
pipelinefunction.taskoptionalpipeline(model="gpt2")should not be enough (will rely on the hub).pipeline_classoverridable to ease override for users of thepipelinefunction.pipeline(model="gpt2", pipeline_class=MyPipeline)should enable you to use whateverpipeline you want.
Related to #14278
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik